fix(android): Remove isNewArchitectureEnabled check#1047
Open
gabrieldonadel wants to merge 2 commits intocallstack:masterfrom
Open
fix(android): Remove isNewArchitectureEnabled check#1047gabrieldonadel wants to merge 2 commits intocallstack:masterfrom
gabrieldonadel wants to merge 2 commits intocallstack:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the isNewArchitectureEnabled() check from the Android build configuration, as React Native 0.82+ no longer allows disabling the new architecture. The library is now new architecture only, making these conditional checks obsolete.
Key changes:
- Removed the
isNewArchitectureEnabled()function definition - Removed conditional checks around new architecture features
- Simplified build configuration to always assume new architecture is enabled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
krozniata
approved these changes
Dec 17, 2025
troZee
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting from react-native 0.82, users can no longer disable the new architecture in their projects, and because of that, the
newArchEnabledproperty ingradle.propertiesis no longer required. The problem is that we still check specifically forrootProject.hasProperty("newArchEnabled")inandroid/build.gradle.Now that this library is new arch only we can simply skip this check.
Test Plan
In a react-native project running 0.82+, remove the
newArchEnabledproperty fromgradle.propertiesand buildChecklist